Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalization of tflint call for FAST stages #2225

Merged
merged 8 commits into from
Apr 18, 2024
Merged

Generalization of tflint call for FAST stages #2225

merged 8 commits into from
Apr 18, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Apr 18, 2024 •
edited
Loading

This got a bit uglier than in the comment. Things to probably align:

  • fast stage tests - align all file names with new *.tfvars file name
  • fix tests

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@github-actions github-actions bot added the on:tools New or changed tool label Apr 18, 2024
juliocc
juliocc approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's tricker than it looks ;)

@wiktorn wiktorn requested a review from juliocc April 18, 2024 18:12
@wiktorn
Copy link
Collaborator Author

wiktorn commented Apr 18, 2024 •
edited
Loading

It grew even larger. I also consider running s/simple/stage/g on file names / content.

Also, an even more sophisticated solution is to go through tftest.yaml files and parse out from there what's needed...

@juliocc juliocc merged commit 024d325 into master Apr 18, 2024
13 checks passed
@juliocc juliocc deleted the wiktorn/tflint branch April 18, 2024 19:04
dibaskar-google pushed a commit to dibaskar-google/cloud-foundation-fabric that referenced this pull request May 14, 2024
@wiktorn @dibaskar-google
Generalization of tflint call for FAST stages (GoogleCloudPlatform#2225)
d1e0e48 
* Generalization of tflint call for FAST

* Fix tfvars path

* Fix tfvars path - depending where the file is

* Fix regex

* Reeanble linting

* Align test directory to stage name

* Align all fast stages to use tftest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc Awaiting requested review from juliocc

Assignees
No one assigned
Labels
on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktorn @juliocc