-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project quotas factory #2211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, but do you think one factory per project is a valid use case? For the type of usage I've seen, I would think of
- support for multiple projects in a single factory, only used to control quotas
- simple support for quotas in a project factory project-level YAML file, to control specific quotas at project creation
Do you have an actual use case for the factory in this pr?
Updated the description above. My use-case is the - application teams. They do get a project from central team, but they are free to manage IAM and quotas locally. They have just a bunch of projects (few projects per environment), where they do need to manage the quotas and one IaC service account per project (limited to the project scope). Multiple-project quota-only factory could be used here as well, but in this case, it would be used just for single project. |
Makes sense, thanks. What would you think of a slightly different factory, that used one file per region respecting the format you get with |
Good idea. I still think it is necessary to keep current structure as well, for all the quotas that are not region based or have multiple dimensions, and user wants to specify them all. This will allow some foot-shooting, when user will specify the same quota twice with different values for the same dimensions. The other approach is to "re-key" them by dimensions and quota_id's. |
Well compute quotas (are there any others?) are either regional or global, and the structure is identical. My preference would be for using one file per region, and one file with "global", and reusing the format exported by gcloud. Dimension is just the region for compute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, new format has dimensions and is what we need so Wiktor wins this discussion. :)
Follow up on #2210 - add factory to manage quotas.
Use cases for this factory:
project_create = false
), especially when using GPUsChecklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py