-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gke-cluster-standard): Set optionnal default_node_pool
configuration
#2175
Merged
juliocc
merged 3 commits into
GoogleCloudPlatform:master
from
anthonyhaussman:feat/gke-cluster-standard/default_node_pool_option
Mar 26, 2024
Merged
feat(gke-cluster-standard): Set optionnal default_node_pool
configuration
#2175
juliocc
merged 3 commits into
GoogleCloudPlatform:master
from
anthonyhaussman:feat/gke-cluster-standard/default_node_pool_option
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyhaussman
force-pushed
the
feat/gke-cluster-standard/default_node_pool_option
branch
from
March 26, 2024 11:11
4aa95f8
to
3729d38
Compare
anthonyhaussman
force-pushed
the
feat/gke-cluster-standard/default_node_pool_option
branch
from
March 26, 2024 11:14
3729d38
to
9ed6368
Compare
Thanks for the thorough explanation, it kind of does make sense to me. @juliocc WDYT? |
anthonyhaussman
force-pushed
the
feat/gke-cluster-standard/default_node_pool_option
branch
3 times, most recently
from
March 26, 2024 13:03
100d57e
to
4b79ab5
Compare
TIL. Makes complete sense sense. |
ludoo
reviewed
Mar 26, 2024
juliocc
requested changes
Mar 26, 2024
anthonyhaussman
force-pushed
the
feat/gke-cluster-standard/default_node_pool_option
branch
from
March 26, 2024 14:45
4b79ab5
to
835c2f9
Compare
ludoo
approved these changes
Mar 26, 2024
auto-merge was automatically disabled
March 26, 2024 14:47
Head branch was pushed to by a user without write access
anthonyhaussman
force-pushed
the
feat/gke-cluster-standard/default_node_pool_option
branch
from
March 26, 2024 14:47
835c2f9
to
3186f2d
Compare
anthonyhaussman
force-pushed
the
feat/gke-cluster-standard/default_node_pool_option
branch
from
March 26, 2024 14:48
3186f2d
to
fff098a
Compare
juliocc
approved these changes
Mar 26, 2024
auto-merge was automatically disabled
March 26, 2024 15:10
Head branch was pushed to by a user without write access
anthonyhaussman
force-pushed
the
feat/gke-cluster-standard/default_node_pool_option
branch
from
March 26, 2024 15:11
56c81ae
to
2e42ecb
Compare
anthonyhaussman
deleted the
feat/gke-cluster-standard/default_node_pool_option
branch
March 28, 2024 12:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the possibility to set and initialize a
default_node_pool
to correctly size GKE Control-Planes in a restoration process.Explanation
As I understand the reason for disabling the creation of the
default_node_pool
is to take advantage of thegke-nodepool
module, I want to give the option to add this node_pool with a specific size to size Control-Planes during a Disaster Recovery Plan using the GKE restoration features.To add more details, in my test when I used the
gke-nodepool
to add a nodePool after the creation of the cluster and launch directly a restore process, this one failed due to the resize of Control-Plane by adding nodes.This action can take a long time, around 45 minutes.
By setting the initial
default_node_pool
at the creation of the cluster, GKE Control-Planes do not need to resize and improve the restoration process time by a lot.That's why I would like to add this option.
By default, it keeps the same behavior as before and does not create the
default_node_pool
.Furthermore, a
validation
block has been added to force to set theinitial_node_count
ifremove_pool
has been disabled.The option can be simply added by setting:
I hope to have been clear enough. 🙏
Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py