Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitlab blueprint #2110

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Gitlab blueprint #2110

merged 6 commits into from
Feb 27, 2024

Conversation

simonebruzzechesse
Copy link
Collaborator

New Gitlab blueprint.

Features and open points

  • Integrations
    • Identity
      • SAML
    • Email:
      • Gmail / Workspace
      • Sendgrid
  • ILB
  • MIG
  • Gitaly
  • HTTPS SSL
  • Gitlab SSH on port 2222
  • Check object store, use GCS wherever possible
  • Cloud SQL HA
  • Memorystore HA?
  • Integration with Cloud Logging for Gitlab running on Docker container

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

juliocc
juliocc approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice work.

Left a few comments below.

blueprints/third-party-solutions/README.md Outdated Show resolved Hide resolved
blueprints/third-party-solutions/gitlab/gitlab.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/gitlab/gitlab.tf Show resolved Hide resolved
blueprints/third-party-solutions/gitlab/outputs.tf Show resolved Hide resolved
blueprints/third-party-solutions/gitlab/services.tf Show resolved Hide resolved
blueprints/third-party-solutions/gitlab/variables.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/gitlab/variables.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/gitlab/variables.tf Show resolved Hide resolved
blueprints/third-party-solutions/gitlab/variables.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/gitlab/variables.tf Outdated Show resolved Hide resolved
@simonebruzzechesse simonebruzzechesse merged commit a34d93f into master Feb 27, 2024
13 checks passed
@simonebruzzechesse simonebruzzechesse deleted the bruzz/gitlab branch February 27, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:blueprints on:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonebruzzechesse @juliocc