Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitlab Runner blueprint #2106

Merged
merged 2 commits into from
May 27, 2024
Merged

Gitlab Runner blueprint #2106

merged 2 commits into from
May 27, 2024

Conversation

simonebruzzechesse
Copy link
Collaborator

Add Gitlab Runner blueprint for the following exectuors:

  • Docker Executor
  • Docker Autoscaler Executor (BETA)

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

juliocc
juliocc requested changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

left a few comments

blueprints/third-party-solutions/gitlab-runner/main.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/gitlab-runner/main.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/gitlab-runner/main.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/gitlab-runner/variables.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/gitlab-runner/main.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/gitlab-runner/assets/startup-script.sh.tpl Outdated Show resolved Hide resolved
@ludoo
Copy link
Collaborator

ludoo commented Apr 20, 2024

@simonebruzzechesse do you still plan to work on this? Can we close the PR and reopen when you're ready?

@simonebruzzechesse simonebruzzechesse force-pushed the bruzz/gitlab-runner branch 2 times, most recently from e13aefe to b502dd3 Compare May 20, 2024 16:04
@simonebruzzechesse simonebruzzechesse force-pushed the bruzz/gitlab-runner branch 2 times, most recently from 72c0bf4 to 4a3bbc7 Compare May 23, 2024 09:39
@juliocc juliocc merged commit f4f891d into master May 27, 2024
13 checks passed
@juliocc juliocc deleted the bruzz/gitlab-runner branch May 27, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:blueprints on:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonebruzzechesse @ludoo @juliocc