Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all project_parent_ids fields optional #2101

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Make all project_parent_ids fields optional #2101

merged 2 commits into from
Feb 20, 2024

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Feb 20, 2024

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliocc juliocc requested a review from ludoo February 20, 2024 15:06
@juliocc juliocc enabled auto-merge (squash) February 20, 2024 15:07
ludoo
ludoo approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, we need to eventually revisit all FAST variables to adopt optional (some parts of FAST are old by now) :)

@juliocc juliocc merged commit b82f008 into master Feb 20, 2024
13 checks passed
@juliocc juliocc deleted the jccb/fast-optional-parent-ids branch February 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:FAST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliocc @ludoo @wiktorn