Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module Data Catalog Tag - Add support for types #2100

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Module Data Catalog Tag - Add support for types #2100

merged 5 commits into from
Feb 22, 2024

Conversation

lcaggio
Copy link
Collaborator

@lcaggio lcaggio commented Feb 20, 2024

Module Data Catalog Tag - Add support for types

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@lcaggio lcaggio marked this pull request as ready for review February 20, 2024 13:56
@lcaggio lcaggio requested a review from wiktorn February 20, 2024 13:57
wiktorn
wiktorn approved these changes Feb 20, 2024
View reviewed changes
modules/data-catalog-tag/main.tf Outdated Show resolved Hide resolved
modules/data-catalog-tag/main.tf Outdated Show resolved Hide resolved
modules/data-catalog-tag/variables.tf Show resolved Hide resolved
modules/data-catalog-tag/README.md Outdated Show resolved Hide resolved
lcaggio
lcaggio commented Feb 22, 2024
View reviewed changes
Copy link
Collaborator Author

@lcaggio lcaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementing your comments

modules/data-catalog-tag/variables.tf Show resolved Hide resolved
modules/data-catalog-tag/README.md Show resolved Hide resolved
modules/data-catalog-tag/README.md Show resolved Hide resolved
@lcaggio lcaggio merged commit 1c26c8f into master Feb 22, 2024
13 checks passed
@lcaggio lcaggio deleted the lcaggio/tag-add-support branch February 22, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcaggio @wiktorn