Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add analytics hub module #2087

Merged
merged 7 commits into from
Feb 19, 2024
Merged

add analytics hub module #2087

merged 7 commits into from
Feb 19, 2024

Conversation

thinhha
Copy link
Contributor

@thinhha thinhha commented Feb 17, 2024

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@thinhha thinhha requested review from ludoo, lcaggio and juliocc February 17, 2024 16:19
ludoo
ludoo requested changes Feb 17, 2024
View reviewed changes
modules/analytics-hub/variables.tf Outdated Show resolved Hide resolved
modules/analytics-hub/variables.tf Outdated Show resolved Hide resolved
modules/analytics-hub/iam.tf Outdated Show resolved Hide resolved
@thinhha thinhha requested a review from ludoo February 19, 2024 14:06
ludoo
ludoo approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the top-level repo and modules folder READMEs, so the module is listed there?

@thinhha thinhha merged commit 82f11e7 into master Feb 19, 2024
13 checks passed
@thinhha thinhha deleted the analytics-hub branch February 19, 2024 15:55
@thinhha
Copy link
Contributor Author

thinhha commented Feb 19, 2024

Thanks for your review @ludoo. I've raised a separate PR for README in #2094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@lcaggio lcaggio Awaiting requested review from lcaggio

@juliocc juliocc Awaiting requested review from juliocc

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinhha @ludoo