Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Fabric modules in blueprints/networking/psc-glb-and-armor #2076

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Feb 14, 2024

Use Fabric modules in blueprints/networking/psc-glb-and-armor

Few minor improvements along the way:

  • remove unnecessary subnets (additional NAT for PSC, VMS)
  • remove NOOP compute engine instance
  • added url_rewrite for service b, so the service actually works as expected
  • added allow-list for consumer projects that can connect to the producers PSC service
  • improved curl to it uses terraform output for find the IP address
  • added possibility to meaningfully create projects (using prefixes, parent etc.)

This that are different , though not sure if that's OK:

  • added network in consumer project, so PSC attachment doesn't complain on missing default network, not sure if that was expected

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@wiktorn wiktorn force-pushed the wiktorn-psc-glb-fabric-modules branch from e2b2ab4 to 60b4a13 Compare February 15, 2024 19:44
@wiktorn wiktorn merged commit e02d871 into master Feb 15, 2024
13 checks passed
@wiktorn wiktorn deleted the wiktorn-psc-glb-fabric-modules branch February 15, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants