Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated path matchers to be more user friendly, added better test exa… #2075

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

bswenka
Copy link
Collaborator

@bswenka bswenka commented Feb 14, 2024

…mples in README.md

Updated path matchers to be more user friendly based on our Cloud Run example app, and added better test examples in the README that use these path matchers.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@bswenka bswenka requested a review from wiktorn February 14, 2024 21:54
@bswenka bswenka force-pushed the bswenka/change-url-maps-to-be-more-test-friendly branch from e703236 to be44ad9 Compare February 15, 2024 01:49
@wiktorn wiktorn enabled auto-merge (rebase) February 15, 2024 17:26
@wiktorn wiktorn merged commit d158aec into master Feb 15, 2024
13 checks passed
@wiktorn wiktorn deleted the bswenka/change-url-maps-to-be-more-test-friendly branch February 15, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants