Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests - vertex mlops and net-address #2072

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fix e2e tests - vertex mlops and net-address #2072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5b713d
Fix non-empty plan after apply
wiktorn Feb 12, 2024
f6ccf93
Use less conflicting IP
wiktorn Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions blueprints/data-solutions/vertex-mlops/vertex.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ resource "google_notebooks_instance" "playground" {

instance_owners = try(tolist(var.notebooks[each.key].owner), null)
service_account = module.service-account-notebook.email
service_account_scopes = [
"https://www.googleapis.com/auth/cloud-platform",
"https://www.googleapis.com/auth/userinfo.email",
]


metadata = {
notebook-disable-nbconvert = "false"
Expand Down
2 changes: 1 addition & 1 deletion modules/net-address/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ module "addresses" {
subnetwork = var.subnet.self_link
}
ilb-2 = {
address = "10.0.16.2"
address = "10.0.16.102"
region = var.region
subnetwork = var.subnet.self_link
}
Expand Down
2 changes: 1 addition & 1 deletion tests/modules/net_address/examples/internal.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ values:
region: europe-west8
subnetwork: subnet_self_link
module.addresses.google_compute_address.internal["ilb-2"]:
address: 10.0.16.2
address: 10.0.16.102
address_type: INTERNAL
labels: null
name: ilb-2
Expand Down
Loading