-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data catalog Tag module #2060
Data catalog Tag module #2060
Conversation
This looks great! Thanks Lorenzo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder about actual usage. @lcaggio based on your experience - is it multiple templates applied to single parent, or rather one template per parent?
Also, can template location can be different than tag location?
I wonder about remodeling this structure a bit, to reduce boilerplate code, like for example if I have multiple column
on one parent
to tag
|
||
resource "google_data_catalog_tag" "engine" { | ||
for_each = local.factory_tag_template | ||
parent = "projects/${each.value.project_id}/locations/${each.value.project_id}/entryGroups/@bigquery/entries/${trim(base64encode(each.value.parent), "=")}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parent = "projects/${each.value.project_id}/locations/${each.value.project_id}/entryGroups/@bigquery/entries/${trim(base64encode(each.value.parent), "=")}" | |
parent = "projects/${each.value.project_id}/locations/${each.value.location}/entryGroups/@bigquery/entries/${trim(base64encode(each.value.parent), "=")}" |
project_id = "project-data-product" | ||
parent = "projects/project-data-product/datasets/landing/tables/countries" | ||
column = "country" | ||
location = "europe-west-1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
location = "europe-west-1" | |
location = "europe-west1" |
?
Thanks @wiktorn. From my experience, multiple Tag can be assigned to a resource (e.g. multiple tag on a dataset, less common for columns). I think location can be different, but I am going to use this module in 2 customers really soon and I will check the structure of the module with reality of customer needs. I will update the module accordingly. |
Data catalog Tag module. This is a simple module. The main reason for creating a module is the Tag factory.
Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py