Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postpone setting essential contacts until provisioning using SA #2057

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Feb 7, 2024

Right now, during first apply of bootstrap (as a user, not impersonating SA), setting essential contacts fails with:

│ Error: Error creating Contact: googleapi: Error 403: Your application is authenticating by using local Application Default Credentials. The essentialcontacts.googleapis.com API requires a quota project, which is not set by default. To learn how to set your quota project, see https://cloud.google.com/docs/authentication/adc-troubleshooting/user-creds .

I assume that this is due to essentialcontacts API not being enabled in default gcloud project. This can be worked around with USER_PROJECT_OVERRIDE=true and GOOGLE_BILLING_PROJECT=your-quota-project, but lest maybe not burden users with that, as this may be safely postponed to the moment when service account is used.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn wiktorn enabled auto-merge (rebase) February 7, 2024 16:14
@wiktorn wiktorn merged commit da11396 into master Feb 7, 2024
13 checks passed
@wiktorn wiktorn deleted the wiktorn-fix-essential-contacts branch February 7, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants