Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging for default ingress rules in FAST (CSPR-related) #2030

Merged
merged 5 commits into from
Jan 30, 2024
Merged

logging for default ingress rules in FAST (CSPR-related) #2030

merged 5 commits into from
Jan 30, 2024

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Jan 30, 2024

Fixes #2024

@juliocc juliocc requested review from ludoo and sruffilli January 30, 2024 16:12
ludoo
ludoo approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped a comment on a potential permadiff, but my assumption needs to be verified :)

@juliocc juliocc changed the title Jccb/fix 2024 fast ingress logging logging for default ingress rules in FAST Jan 30, 2024
@juliocc juliocc marked this pull request as ready for review January 30, 2024 16:31
@juliocc juliocc enabled auto-merge (squash) January 30, 2024 16:41
@juliocc juliocc merged commit da95434 into master Jan 30, 2024
13 checks passed
@juliocc juliocc deleted the jccb/fix-2024-fast-ingress-logging branch January 30, 2024 16:53
@ludoo ludoo changed the title logging for default ingress rules in FAST logging for default ingress rules in FAST (CSPR-related) Jan 31, 2024
@ludoo ludoo added the cspr label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@sruffilli sruffilli Awaiting requested review from sruffilli

Assignees
No one assigned
Labels
cspr on:FAST on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firewall Logging Default Ingress Deny
2 participants
@juliocc @ludoo