Add support for essential contacts to FAST (CSPR-related) #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
changed the title
wiktorn
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2006
Essential contacts are added to FAST stages 0, 1, 2 taking care to avoid setting them with too loose granularity (e.g. org level) as they inherit down, and to leave them in control of the appropriate team (e.g. networking team can manage essential contacts for their context).
Stages 3 are effectively managed by the respective blueprints, so that needs to be tackled there. The project factory should already support essential contacts as it basically proxies the project module.
This PR also adds a few missing roles to the project factory read-only service account in stage 1, and adds the proper dependencies for essential contacts in the resource management modules.