Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DNS E2E test + add one to net-lb-app-int-cross-region #1993

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Fix DNS E2E test + add one to net-lb-app-int-cross-region #1993

merged 6 commits into from
Jan 23, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Jan 19, 2024

  • fixed end-to-end tests for DNS
  • adapted one test in net-lb-app-int-cross-region for end-to-end testing
  • created fixture that creates net-lb-app-int-cross-region balancer, that is used by DNS test

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn wiktorn requested a review from apichick January 19, 2024 14:49
@juliocc juliocc merged commit 277777d into master Jan 23, 2024
13 checks passed
@juliocc juliocc deleted the dns_e2e_fix branch January 23, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

@apichick apichick Awaiting requested review from apichick

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wiktorn @juliocc @ludoo