Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Data platform foundation #1992

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Fix Data platform foundation #1992

merged 3 commits into from
Jan 20, 2024

Conversation

lcaggio
Copy link
Collaborator

@lcaggio lcaggio commented Jan 18, 2024 •
edited by ludoo
Loading

[Data Platform foundation] PR fixes:

  • GCS location
  • Project create logic

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@lcaggio lcaggio marked this pull request as ready for review January 19, 2024 08:36
@juliocc juliocc force-pushed the lcaggio/fix-dpf-location branch from 140b5f8 to d6ec659 Compare January 19, 2024 08:59
@lcaggio lcaggio requested review from aymanfarhat and juliocc and removed request for aymanfarhat January 19, 2024 14:23
@ludoo ludoo merged commit 208902c into master Jan 20, 2024
13 checks passed
@ludoo ludoo deleted the lcaggio/fix-dpf-location branch January 20, 2024 07:49
@ludoo ludoo mentioned this pull request Jan 26, 2024
Closed
@ludoo ludoo added the cspr label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@juliocc juliocc Awaiting requested review from juliocc

@aymanfarhat aymanfarhat Awaiting requested review from aymanfarhat

Assignees
No one assigned
Labels
cspr on:blueprints on:FAST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcaggio @ludoo @juliocc