Add example to FAST GKE stage, streamline GKE Hub module variables and usage #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
changed the title
juliocc
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1975 via slight rewording in the stage documentation, and an actual example of using it to manage private clusters.
Defaulting to private clusters in the stage is problematic as we would need to provide one CIDR range per cluster, maintain the range association if the clusters variable changes, and all this would make the stage more complex for very little gain.
The README file now clearly states this stage is designed with private clusters in mind, and provides an example that shows private cluster creation. This should be enough to clarify our security stance, especially given this is not a "fire and forget" stage but one that requires actual thought is given to its configuration.
This PR also implements optionals in the GKE Hub module and associated blueprints, and provides part of the solution for #1515 where autopilot support is still missing.