Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ANY_USER_ACCOUNT in module vpc-sc egress rule. #1966

Conversation

xjantoth
Copy link
Contributor

@xjantoth xjantoth commented Jan 8, 2024

This PR enables to support keyword ANY_USER_ACCOUNT when crafting VPC SC egress rule.
This keyword (identity_type) is currently not enabled by validation block in modules/vpc-sc/variable.tf.

Despite the fact that this option is specifically not enabled by fast vpc-sc module, it is indeed fully supported by underlying terraform resource google_access_context_manager_service_perimeters.

Desired state:
image

I applicable, I acknowledge that I have:

[ x] Read the contributing guide
[ x] Ran terraform fmt on all modified files
[ x] Regenerated the relevant README.md files using tools/tfdoc.py
[ x] Made sure all relevant tests pass

Copy link

google-cla bot commented Jan 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@juliocc
Copy link
Collaborator

juliocc commented Jan 8, 2024

Nice catch. Thanks for the fix @xjantoth!

Can you sign the CLA so we can go ahead and merge it?

@juliocc juliocc merged commit d1746b8 into GoogleCloudPlatform:master Jan 8, 2024
9 checks passed
@juliocc
Copy link
Collaborator

juliocc commented Jan 8, 2024

Can you sign the CLA so we can go ahead and merge it?

Ignore, you already did :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants