Add end-to-end tests for net-lb-app-ext-regional #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktorn
force-pushed
the
wiktorn-e2e_test_fixturization
branch
from
12efb77 to
021555c
Compare
HTTP to HTTPS needs work, now fails with:
Error: Error creating ForwardingRule: googleapi: Error 400: Invalid value for field 'resource.IPAddress': '34.160.52.156'. Invalid IP address specified., invalid
with module.ralb-test-0-redirect.google_compute_forwarding_rule.default,
on fabric/modules/net-lb-app-ext-regional/main.tf line 32, in resource "google_compute_forwarding_rule" "default":
32: resource "google_compute_forwarding_rule" "default" {
wiktorn
force-pushed
the
wiktorn-e2e_test_fixturization
branch
from
021555c to
f734503
Compare
ludoo
approved these changes
Jan 6, 2024
wiktorn
force-pushed
the
wiktorn-e2e_test_fixturization
branch
from
f734503 to
dc7c2e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tierfor external addresses in modules/net-address, as regional lb supports only STANDARD networkfixtures/compute-mig-bc.tftofixtures/compute-vm-group-bc.tfas it creates unmanaged groupChecklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py