Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create bigtable service identity with project if api is enabled #1958

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Create bigtable service identity with project if api is enabled #1958

merged 3 commits into from
Jan 6, 2024

Conversation

steenblik
Copy link
Collaborator

Create service identity for bigtableadmin in the project module if the service is enabled.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

wiktorn
wiktorn approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Big table admin has no roles by default.

@steenblik
Copy link
Collaborator Author

@wiktorn - I'm not able to merge. Would you mind doing it? Thanks!

@ludoo
Copy link
Collaborator

ludoo commented Jan 5, 2024

Jason check your mail, I just added you as a repo user.

@steenblik steenblik merged commit e106649 into GoogleCloudPlatform:master Jan 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steenblik @ludoo @wiktorn