Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for net_lb_app_ext module #1957

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Add e2e test for net_lb_app_ext module #1957

merged 2 commits into from
Jan 5, 2024

Conversation

andybubu
Copy link
Contributor

@andybubu andybubu commented Jan 4, 2024

This PR is adds end-to-end test for net-lb-app-ext module leveraging fixtures #1914

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn wiktorn marked this pull request as ready for review January 5, 2024 08:48
@wiktorn wiktorn enabled auto-merge (rebase) January 5, 2024 08:48
wiktorn
wiktorn approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Andy, very clean PR!

@wiktorn wiktorn merged commit 3edacd0 into GoogleCloudPlatform:master Jan 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andybubu @wiktorn @ludoo