Add support for Cloud Run v2 jobs #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktorn
force-pushed
the
wiktorn-cloudrun-jobs
branch
from
8fbf94e to
030f02e
Compare
|
I'll add more E2E tests, as we have fixtures. |
juliodiez
reviewed
Dec 29, 2023
* create a separate file for service creation (service.tf) and job (job.tf) - for easy comparison * add E2E tests where possibile * remove default value for input variable `region` * fix subnet range VPC Access Connector example * add creation of service account for audit logs call (trigger requires service account) * use provided trigger service account email in `local.trigger_sa_email`, so explicitly provided SA is passed to trigger * set default value for vpc_connector_create.throughput.max, to match what is set by GCP API, as provider uses wrong default of 300 which results in perma-diff * create inventory fiels for all examples
Global changes * (tests) add input variable `project_number`, to allow assigning IAM permissions to Service Accounts in fixtures * (tests) fix not outputting the path, when object is not found in inventory * (tests) fix `create_e2e_sandbox.sh` - now it properly finds root of the repo Secret Manager * added `version_versions` output, to allow specifying versions in other modules. `versions` is sensitive and it makes it unsuitable for `for_each` values New test fixtures * `pubsub.tf` - creating one topic * `secret-credential.tf` - creating Secret Manager `credential` secret * `shared-vpc.tf` - creating two projects (host and service), and vpc in host project * `vpc-connector.tf` - creating VPC Access Connector instance Cloud Run v2 module changes * fix non-empty plan after apply when providing `volumes` with empty/null `cloud_sql_instances` * update inventory files * add additional E2E tests using fixtures
Co-authored-by: Julio Diez <[email protected]>
wiktorn
force-pushed
the
wiktorn-cloudrun-jobs
branch
from
27b196d to
5d0e7e4
Compare
|
@wiktorn can we merge this? I don't expect clarification on the last item to come anytime soon. :) |
Happy to merge it, just need a review :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global changes
project_numberforexamplesandexamples_e2etests to allow assigning IAM permissions to Service Accounts in fixturescreate_e2e_sandbox.sh- now it properly finds root of the repoSecret Manager
version_versionsoutput, to allow specifying versions in other modules.versionsis sensitive and it makes it unsuitable forfor_eachvaluesNew test fixtures
pubsub.tf- creating one topicsecret-credential.tf- creating Secret Managercredentialsecretshared-vpc.tf- creating two projects (host and service), and vpc in host projectvpc-connector.tf- creating VPC Access Connector instanceCloud Run v2 module changes
regionlocal.trigger_sa_email, so explicitly provided SA is passed to triggervolumeswith empty/nullcloud_sql_instancesChecklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py