Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable region #1953

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Fix variable region #1953

merged 1 commit into from
Dec 28, 2023

Conversation

andybubu
Copy link
Contributor

@andybubu andybubu commented Dec 28, 2023 •
edited by wiktorn
Loading

This PR changes variable region's default value in example tests to real region value.

Some of the modules parse the region name to decide whether to create regional or zonal resources.

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

wiktorn
wiktorn approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy

@wiktorn wiktorn merged commit 2ad109a into GoogleCloudPlatform:master Dec 28, 2023
9 checks passed
@ludoo ludoo added the on:tools New or changed tool label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

Assignees
No one assigned
Labels
on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andybubu @wiktorn @ludoo