Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composer blueprints improvements #1952

Merged
merged 6 commits into from
Dec 29, 2023
Merged

Composer blueprints improvements #1952

merged 6 commits into from
Dec 29, 2023

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Dec 28, 2023

  • add composer service account to outputs
  • use GCP defaults in workloads_config to allow partially specifying config

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn
Provider doesn't set defaults on config
4cbf42c 
Can't provide just one size (like `web_server` or `triggerrer`) because
of no defaults are taken:
module.composer.google_composer_environment.env: Modifying... [id=***]
╷
│ Error: googleapi: Error 400: Found 6 problems:
│       1) You have to specify Scheduler CPUs not lower than 0.5.
│       2) You have to specify number of schedulers larger than 0.
│       3) You have to specify Web Server CPUs not lower than 0.5.
│       4) You have to specify Worker CPUs not lower than 0.5.
│       5) You have to specify minimum number of workers larger than 0.
│       6) Triggerer memory must be between 1.00GB and 6.50GB for given vCpu

So provide the defaults as set workloads_config == null
@wiktorn
Add service account email to outputs to manage its permissions
7fec7d4
@wiktorn wiktorn enabled auto-merge (rebase) December 28, 2023 10:27
@wiktorn wiktorn merged commit 6c258e6 into master Dec 29, 2023
13 checks passed
@wiktorn wiktorn deleted the wiktorn-composer-improvements branch December 29, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:blueprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktorn @juliocc