Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify organization tags.tf locals #1932

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Simplify organization tags.tf locals #1932

merged 5 commits into from
Dec 18, 2023

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Dec 18, 2023

I was about to add tags to the project module and I noticed some on of the locals in modules/organization/tags.tf could be simplified leveraging the guarantees of optional types.

@juliocc juliocc requested a review from ludoo December 18, 2023 12:38
@juliocc juliocc marked this pull request as ready for review December 18, 2023 12:38
@juliocc juliocc force-pushed the jccb/simplify-org-tags branch from 846232e to 7dc3ff5 Compare December 18, 2023 12:39
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@github-actions github-actions bot added the on:tools New or changed tool label Dec 18, 2023
@juliocc juliocc force-pushed the jccb/simplify-org-tags branch from 4ad8d50 to 15fd72f Compare December 18, 2023 14:48
@juliocc juliocc force-pushed the jccb/simplify-org-tags branch from 15fd72f to 3040926 Compare December 18, 2023 14:49
@juliocc juliocc enabled auto-merge (squash) December 18, 2023 14:49
@juliocc juliocc removed the on:tools New or changed tool label Dec 18, 2023
@github-actions github-actions bot added on:FAST on:tools New or changed tool labels Dec 18, 2023
@juliocc juliocc merged commit b6e0557 into master Dec 18, 2023
13 checks passed
@juliocc juliocc deleted the jccb/simplify-org-tags branch December 18, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants