Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail on missing project in quota monitor blueprint #1927

Closed
wants to merge 2 commits into from

Conversation

maunope
Copy link
Collaborator

@maunope maunope commented Dec 13, 2023

Refactored fetch method in Quota Monitor main.py to raise an exception upon !=200 response codes, instead of a system exit.
updated callers to handle requests.exceptions.HTTPError

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • [X ] Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@maunope maunope requested a review from ludoo December 13, 2023 13:54
@ludoo ludoo changed the title Quota monitr blueprint, HTTP errors handling Don't fail on missing project in quota monitor blueprint Dec 13, 2023
@ludoo
Copy link
Collaborator

ludoo commented Dec 15, 2023

Mauri I'm closing this in favor of #1931

@ludoo ludoo closed this Dec 15, 2023
@ludoo ludoo deleted the maunope_quota_monitor_fetch_failmanagement branch July 20, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants