Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed deprecated variable and added labels #1923

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Removed deprecated variable and added labels #1923

merged 2 commits into from
Dec 12, 2023

Conversation

luigi-bitonti
Copy link
Contributor

instance_type variable was removed because is deprecated. labels variable was added.
display_name was fixed.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

ludoo
ludoo approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ludoo ludoo enabled auto-merge (squash) December 12, 2023 18:19
@ludoo ludoo merged commit ef4095f into GoogleCloudPlatform:master Dec 12, 2023
9 checks passed
@luigi-bitonti luigi-bitonti deleted the BigTable_fix branch December 13, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luigi-bitonti @ludoo