Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the possibility to configure maintenance window and deny maintenance period in Cloud SQL module module #1917

Merged
merged 12 commits into from
Dec 11, 2023
Merged

Added the possibility to configure maintenance window and deny maintenance period in Cloud SQL module module #1917

merged 12 commits into from
Dec 11, 2023

Conversation

francesco-pavan-huware
Copy link
Contributor

Added the possibility to configure the following Cloud SQL functionalities in the Cloud SQL module:

  • maintenance window
  • deny maintenance period

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@google-cla Google CLA
Copy link

google-cla bot commented Dec 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@francesco-pavan-huware
Collapsed "deny_maintenance_period" and "maintenance_window" variable…
a1eda24 
…s into a single variable called "maintenance_config"
ludoo
ludoo requested changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks a lot for being super quick!

Dropped a couple minor comments, then this should be good to go.

modules/cloudsql-instance/variables.tf Outdated Show resolved Hide resolved
modules/cloudsql-instance/main.tf Outdated Show resolved Hide resolved
modules/cloudsql-instance/variables.tf Outdated Show resolved Hide resolved
ludoo
ludoo requested changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, one last bit is validation for the update track then we can merge :)

ludoo
ludoo approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for being patient with our review comments! :)

@ludoo ludoo enabled auto-merge (squash) December 11, 2023 16:47
@ludoo ludoo merged commit d2d62b7 into GoogleCloudPlatform:master Dec 11, 2023
9 checks passed
@francesco-pavan-huware francesco-pavan-huware deleted the francesco-pavan-huware/cloud_sql_maintenance_settings branch December 11, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francesco-pavan-huware @ludoo @wiktorn