gke-cluster-standard : Add possibility to enable image streaming feature at cluster level #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noony
force-pushed
the
gke-image-streaming
branch
from
fee2deb to
2fd54cc
Compare
…ure at cluster level
noony
force-pushed
the
gke-image-streaming
branch
from
2fd54cc to
7715b6b
Compare
ludoo
reviewed
Dec 7, 2023
ludoo
approved these changes
Dec 7, 2023
|
Thank you for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module modified : gke-cluster-standard
This PR add to enable_features an entry image_streaming to enable the feature at cluster level.
following documentation of terraform object
google_container_cluster: linkThis activate at cluster level cf screenshot :
it's useful to activate this feature when you only use node auto provisionner and you can't activate this feature on node pools.
Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py