Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First version of Cloud Run module v2 #1902

Merged
merged 16 commits into from
Dec 26, 2023
Merged

First version of Cloud Run module v2 #1902

merged 16 commits into from
Dec 26, 2023

Conversation

juliodiez
Copy link
Collaborator

Cloud Run module v2 to provide new features only available on the v2 of the Cloud Run resource.

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliodiez juliodiez linked an issue Dec 5, 2023 that may be closed by this pull request
Implement Cloud Run module version 2 #1849
Closed
@juliodiez juliodiez marked this pull request as draft December 5, 2023 08:24
@ludoo
Copy link
Collaborator

ludoo commented Dec 12, 2023

Julio, is this waiting for a review?

@juliodiez
Copy link
Collaborator Author

juliodiez commented Dec 12, 2023 via email

@juliodiez juliodiez requested a review from wiktorn December 15, 2023 11:17
wiktorn
wiktorn reviewed Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the direction. My plan is to add here Cloud Run job creation, as only triggers will need to be removed.

modules/cloud-run-v2/variables.tf Outdated Show resolved Hide resolved
modules/cloud-run-v2/variables.tf Show resolved Hide resolved
modules/cloud-run-v2/variables.tf Show resolved Hide resolved
modules/cloud-run-v2/variables.tf Outdated Show resolved Hide resolved
@juliodiez juliodiez requested a review from wiktorn December 21, 2023 16:06
@wiktorn
Copy link
Collaborator

wiktorn commented Dec 21, 2023

LGTM @juliodiez

@juliodiez juliodiez marked this pull request as ready for review December 22, 2023 11:31
@wiktorn
Copy link
Collaborator

wiktorn commented Dec 25, 2023

I allowed myself to do small update to README.md.

Please add links to the new module in /README.md and /modules/README.md and its ready to go.

@juliodiez juliodiez enabled auto-merge December 26, 2023 15:27
@juliodiez
Copy link
Collaborator Author

@wiktorn PTAL (and approve ;)

wiktorn
wiktorn approved these changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

@juliodiez juliodiez merged commit 34cd9d4 into master Dec 26, 2023
13 checks passed
@juliodiez juliodiez deleted the 1849-implement-cloud-run-module-version-2 branch December 26, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

@ludoo ludoo Awaiting requested review from ludoo

@juliocc juliocc Awaiting requested review from juliocc

@apichick apichick Awaiting requested review from apichick

Assignees
No one assigned
Labels
on:documentation on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Cloud Run module version 2
3 participants
@juliodiez @ludoo @wiktorn