Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module for external regional application load balancer #1892

Merged
merged 10 commits into from
Jan 5, 2024
Merged

New module for external regional application load balancer #1892

merged 10 commits into from
Jan 5, 2024

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Nov 30, 2023 •
edited
Loading

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliocc juliocc force-pushed the jccb/regional-net-lb-app-ext branch 2 times, most recently from 6a1f202 to 2734103 Compare January 5, 2024 15:26
@juliocc juliocc force-pushed the jccb/regional-net-lb-app-ext branch from 05f7a3b to b0a7ade Compare January 5, 2024 15:29
@juliocc juliocc marked this pull request as ready for review January 5, 2024 15:31
@juliocc juliocc requested a review from ludoo January 5, 2024 15:32
ludoo
ludoo approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment on possible discrepancies in health checks ( #1928 might have been created after you branched), awesome job!

@juliocc juliocc merged commit 8beb621 into master Jan 5, 2024
13 checks passed
@juliocc juliocc deleted the jccb/regional-net-lb-app-ext branch January 5, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliocc @ludoo