Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F5 deployment blueprint #1883

Merged
merged 3 commits into from
Nov 24, 2023
Merged

F5 deployment blueprint #1883

merged 3 commits into from
Nov 24, 2023

Conversation

LucaPrete
Copy link
Member

The blueprint shows a private IPv4/IPv6 F5 deployment.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@LucaPrete LucaPrete requested a review from ludoo November 23, 2023 15:32
@LucaPrete LucaPrete changed the title Initial commit F5 deployment blueprint Nov 23, 2023
ludoo
ludoo requested changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test example at the bottom of the README. :)

ludoo
ludoo approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chatted f2f, thanks Luca

@LucaPrete LucaPrete merged commit 56fcb4f into master Nov 24, 2023
13 checks passed
@LucaPrete LucaPrete deleted the f5_blueprint_deploy branch November 24, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:blueprints on:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucaPrete @ludoo