Added PSC support to CloudSQL Module #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktorn
requested changes
Nov 21, 2023
juliocc
requested changes
Nov 22, 2023
There was a problem hiding this comment.
The PR that introduced PSC also added two additional (undocumented) fields:
- dns_name not sure what this is but sounds relevant to PSC
- psc_service_attachment_link we should add this as an output
luigi-bitonti
force-pushed
the
feature_psc_cloudsql
branch
2 times, most recently
from
a09840d to
7794b6f
Compare
Thanks, outputs added to the module. dns_name is correlated with PSC. |
wiktorn
reviewed
Nov 22, 2023
luigi-bitonti
force-pushed
the
feature_psc_cloudsql
branch
from
d7302da to
37eda6a
Compare
wiktorn
reviewed
Nov 23, 2023
luigi-bitonti
force-pushed
the
feature_psc_cloudsql
branch
2 times, most recently
from
a518754 to
bf0a5f2
Compare
wiktorn
approved these changes
Nov 23, 2023
luigi-bitonti
force-pushed
the
feature_psc_cloudsql
branch
4 times, most recently
from
e13d892 to
3a91495
Compare
luigi-bitonti
force-pushed
the
feature_psc_cloudsql
branch
from
3a91495 to
3247e44
Compare
juliocc
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR a variable to enable PSC on CloudSQL Instance was introduced. The design of the variables that manage the network has been improved, by introducing network_config variable.
Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py