Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added workstation-cluster module #1871

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Added workstation-cluster module #1871

merged 1 commit into from
Nov 30, 2023

Conversation

apichick
Copy link
Collaborator

Added workstation-cluster module

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@apichick apichick enabled auto-merge November 19, 2023 15:38
@apichick apichick force-pushed the workstation-cluster branch 12 times, most recently from 2a84168 to 89e2194 Compare November 19, 2023 21:41
wiktorn
wiktorn approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM, just a few small things here and there.

blueprints/networking/__need_fixing/onprem-google-access-dns/README.md Outdated Show resolved Hide resolved
blueprints/networking/decentralized-firewall/validator/requirements.txt Outdated Show resolved Hide resolved
modules/workstation-cluster/variables.tf Outdated Show resolved Hide resolved
modules/workstation-cluster/variables.tf Outdated Show resolved Hide resolved
@apichick apichick force-pushed the workstation-cluster branch from 89e2194 to 44b996c Compare November 20, 2023 14:04
@apichick apichick force-pushed the workstation-cluster branch from 44b996c to 0a200e2 Compare November 20, 2023 14:06
juliocc
juliocc requested changes Nov 20, 2023
View reviewed changes
modules/workstation-cluster/variables.tf Outdated Show resolved Hide resolved
modules/workstation-cluster/variables.tf Outdated Show resolved Hide resolved
modules/workstation-cluster/README.md Show resolved Hide resolved
modules/workstation-cluster/README.md Show resolved Hide resolved
modules/workstation-cluster/main.tf Outdated Show resolved Hide resolved
@apichick apichick force-pushed the workstation-cluster branch 4 times, most recently from bdfbe4d to d3ffcee Compare November 20, 2023 14:57
juliocc
juliocc approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@apichick apichick force-pushed the workstation-cluster branch from d3ffcee to 3163873 Compare November 29, 2023 16:40
@apichick apichick force-pushed the workstation-cluster branch from 3163873 to 66bd9d5 Compare November 30, 2023 06:02
@apichick apichick merged commit 6112d06 into GoogleCloudPlatform:master Nov 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sruffilli sruffilli sruffilli left review comments

@wiktorn wiktorn wiktorn approved these changes

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:blueprints on:documentation on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apichick @juliocc @sruffilli @wiktorn