Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End to end tests for Cloud Run + permadiff fixes #1870

Merged
merged 6 commits into from
Nov 18, 2023

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Nov 18, 2023

  • End to end tests for Cloud Run
  • fix reporting non-empty plan after apply
  • fix non-empty plan in Cloud Run in subnet and annotations

E2E test run with a failure on Event Arc.

Closes: #1867


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

+ fix trigger service account
The test fails with:

Error: Error creating Trigger: googleapi: Error 400: Invalid resource state for "": Permission denied while using the Eventarc Service Agent. If you recently started to use Eventarc, it may take a few minutes before all necessary permissions are propagated to the Service Agent. Otherwise, verify that it has Eventarc Service Agent role.

Retryig after 5 minutes fixes that, but thats not an option for
automated tests.
@wiktorn wiktorn merged commit c642c13 into master Nov 18, 2023
13 checks passed
@wiktorn wiktorn deleted the wiktorn-cloudrun-vpc-connector branch November 18, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPC Connector in cloud run module is forced to recreate when not specifying a subnet.
2 participants