Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer module #1866

Conversation

Francesco-cloud24
Copy link
Contributor

Add composer module

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a module for composer as it's a single resource. I don't know how I feel about this, WDYT @juliocc @lcaggio @wiktorn ?

@wiktorn
Copy link
Collaborator

wiktorn commented Nov 16, 2023

We don't have a module for composer as it's a single resource. I don't know how I feel about this, WDYT @juliocc @lcaggio @wiktorn ?

I think that this is exactly the reason we have blueprint instead of module.

There is no much abstraction provided for the user, but brings some complexity, which will grow with future versions of the Composer

@ludoo
Copy link
Collaborator

ludoo commented Nov 16, 2023

We don't have a module for composer as it's a single resource. I don't know how I feel about this, WDYT @juliocc @lcaggio @wiktorn ?

I think that this is exactly the reason we have blueprint instead of module.

There is no much abstraction provided for the user, but brings some complexity, which will grow with future versions of the Composer

Agreed, I would close this PR then. :)

@ludoo ludoo closed this Nov 16, 2023
@Francesco-cloud24 Francesco-cloud24 deleted the add-composer-module branch November 17, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants