Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organization module end-to-end tests #1860

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Organization module end-to-end tests #1860

merged 5 commits into from
Nov 14, 2023

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Nov 14, 2023 •
edited
Loading

  • added tag serial to mark tests to be run serially
  • always run tests using loadgroup distribution to make use of serial tag
  • added end-to-end tests for organization, not adding to custom constraints as the name has to be unique
  • fixed granting custom roles created in the same module call

E2E tests run

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn
Add serialization tag to tests
487da10
@wiktorn
Standarize organization id
bba93dd
@wiktorn
E2E tests for organiation module
7f27161 
* added tag `serial` to mark tests to be run serially
* added end-to-end tests for organization, not adding to custom
  contratints as the name has to be unique
* fixed granting custom roles created in the same module call
ludoo
ludoo reviewed Nov 14, 2023
View reviewed changes
modules/organization/iam.tf Outdated Show resolved Hide resolved
ludoo
ludoo requested changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the added dependency, logically it makes little sense at org level and I remember it triggering issues with FAST when we tried in the past.

@wiktorn wiktorn requested a review from ludoo November 14, 2023 16:31
ludoo
ludoo approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Wiktor!

@wiktorn wiktorn merged commit 03bf0b1 into master Nov 14, 2023
13 checks passed
@wiktorn wiktorn deleted the wiktorn-org-examples branch November 14, 2023 17:55
@ludoo ludoo added the on:tools New or changed tool label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktorn @ludoo