Fix modules to support new Apigee X environment types #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktorn
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Thank you for your contribution.
You will need to run terraform fmt on modified files to make the lint checks pass. Also, you need to update the README's, by:
$ python3 -m venv venv
$ . venv/bin/activate
$ pip installl -r tools/requirements.txt
$ python tools/tfdoc.py modules/apigee
The last thing is, that this requires provider in version 5.4.0, and we are still testing against 5.0.0, hence the failures. I'll create a separate PR to bump the version.
Updated environment members to be alphabetical order
ludoo
requested changes
Nov 4, 2023
added 2 commits
November 4, 2023 14:34
Sorry, didn't realize that. removed the directory. |
ludoo
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py