Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public_access_prevention field to GCS module #1826

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Add public_access_prevention field to GCS module #1826

merged 3 commits into from
Oct 31, 2023

Conversation

devuonocar
Copy link
Contributor

Added public_access_prevention field to GCS module.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

wiktorn
wiktorn approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution. Just a minor remark.

modules/gcs/variables.tf Outdated Show resolved Hide resolved
@wiktorn wiktorn enabled auto-merge October 31, 2023 09:51
@wiktorn wiktorn merged commit 7dd06ae into GoogleCloudPlatform:master Oct 31, 2023
9 checks passed
@devuonocar devuonocar deleted the devuonocar/Add-missing-fields-to-GCS-module branch October 31, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devuonocar @wiktorn