Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billing budget factory #1822

Merged
merged 4 commits into from
Oct 29, 2023
Merged

Billing budget factory #1822

merged 4 commits into from
Oct 29, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Oct 28, 2023

This implements support for a billing budgets factory in the billing account module. A subsequent PR will refactor factories across modules

  • align all factory variables to the same format used here
  • move the project factory to the project module (for projects)
  • move the service account factory to the service account module and add support for the full interface
  • update the FAST project factory to leverage project, service account, and billing budget factories
  • remove the project factory from blueprints and replace the blueprint project factory subfolders with a README file listing all modules that support a factory

@ludoo ludoo enabled auto-merge (squash) October 28, 2023 14:04
@ludoo ludoo requested a review from LucaPrete October 28, 2023 21:36
@ludoo ludoo disabled auto-merge October 29, 2023 10:24
@ludoo ludoo merged commit 671f06a into master Oct 29, 2023
9 checks passed
@ludoo ludoo deleted the ludo/billing-factory branch October 29, 2023 10:24
juliodiez pushed a commit that referenced this pull request Oct 31, 2023
* billing budget factory

* review comment changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants