Fix logic for default source range in firewall ingress rules #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahah yes :) thanks for the reviews! |
…loudPlatform/cloud-foundation-fabric into ludo/net-vpc-firewall-source-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes i bug I observed today in the real world, where an unwanted source range set to 0/0 is added when
sourcesis set to tags or service accountssource_rangesare specifiedThe fix has been tested live with a customer and we have confirmed it removes the unwanted source range, with the resulting rule being identical to one defined int he console with the same input parameters.