FAST: Add access transparency logs to the default sinks #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
reviewed
Oct 24, 2023
There was a problem hiding this comment.
WDYT about bundling them up with the other audit logs, since it will be easy to filter from the log viewer? Pros of this they are easy to turn off, but then they are small so it's not like it would save anything vs leaving them on... I personally prefer less clutter in variables file, YMMV ofc
Makes sense indeed |
ludoo
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds access transparency logs to the default sinks
Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py