Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the repository format in the image_path output #1803

Merged
merged 2 commits into from
Oct 24, 2023
Merged

use the repository format in the image_path output #1803

merged 2 commits into from
Oct 24, 2023

Conversation

Tutuchan
Copy link
Contributor

@Tutuchan Tutuchan commented Oct 24, 2023 •
edited
Loading

The output of the artifact-registry module hardcodes docker as a format in the repository path, which makes it unusable for language repositories.

This PR fixes this.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

juliocc
juliocc approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks!

@juliocc juliocc enabled auto-merge (squash) October 24, 2023 10:03
@juliocc juliocc merged commit 43f7819 into GoogleCloudPlatform:master Oct 24, 2023
9 checks passed
@Tutuchan Tutuchan deleted the fix-artifact-registry-image-path branch October 24, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tutuchan @juliocc