Make extended shared vpc attributes optional in project factory #1796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
coalesce
to detect whethershared_vpc_service_config
is present in a project YAML definition file is problematic, since all arguments tocoalesce
need to have the exact same type. Which then means the variable needs to be fully fleshed out and always include theoptional
attributes, or the two types will not match.Example code needed with the current module:
The above is needlessly verbose, and the error message when an attribute is missing is not intuitive. The code in this PR allows specifying just the project id: