Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F5 blueprint #1787

Merged
merged 3 commits into from
Nov 22, 2023
Merged

F5 blueprint #1787

merged 3 commits into from
Nov 22, 2023

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented Oct 21, 2023 •
edited
Loading

The blueprint allows users to deploy active/active F5 Big-IP VE based LBs, both for internal (L4 ILBs) and external (L4 NLBs) use.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

ludoo
ludoo requested changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, dropped a few comments but happy to discuss f2f or do the changes together of course

blueprints/networking/f5-lb/load_balancers.tf Outdated Show resolved Hide resolved
blueprints/networking/f5-lb/load_balancers.tf Outdated Show resolved Hide resolved
blueprints/networking/f5-lb/main.tf Outdated Show resolved Hide resolved
blueprints/networking/f5-lb/main.tf Outdated Show resolved Hide resolved
blueprints/networking/f5-lb/main.tf Outdated Show resolved Hide resolved
blueprints/networking/f5-lb/variables.tf Outdated Show resolved Hide resolved
blueprints/networking/f5-lb/variables.tf Outdated Show resolved Hide resolved
blueprints/networking/f5-lb/variables.tf Outdated Show resolved Hide resolved
blueprints/networking/f5-lb/variables.tf Outdated Show resolved Hide resolved
@LucaPrete LucaPrete changed the title [WIP for initial code review] F5 blueprint F5 blueprint Oct 31, 2023
@LucaPrete LucaPrete requested a review from ludoo October 31, 2023 12:03
@LucaPrete
Copy link
Member Author

Adding a message to bump the visibility of this :)

ludoo
ludoo requested changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, dropped a few comments mainly on naming.

blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/variables.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/variables.tf Show resolved Hide resolved
blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/variables.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/variables.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/main.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/main.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/main.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/variables.tf Outdated Show resolved Hide resolved
ludoo
ludoo approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luca, we can tweak it after merge. When you're fine with it go ahead and merge.

@LucaPrete LucaPrete merged commit 642f65b into master Nov 22, 2023
13 checks passed
@LucaPrete LucaPrete deleted the f5_blueprint branch November 22, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@juliocc juliocc Awaiting requested review from juliocc

@sruffilli sruffilli Awaiting requested review from sruffilli

@wiktorn wiktorn Awaiting requested review from wiktorn

Assignees
No one assigned
Labels
on:blueprints on:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucaPrete @ludoo