Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-lb-ext: add support for multiple forwarding rules (IPs) and dual-stack (IPv4/IPv6) #1786

Merged
merged 4 commits into from
Oct 21, 2023
Merged

net-lb-ext: add support for multiple forwarding rules (IPs) and dual-stack (IPv4/IPv6) #1786

merged 4 commits into from
Oct 21, 2023

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented Oct 21, 2023 •
edited
Loading

Adding support for:

  • multiple forwarding rules (IPs)
  • dual-stack (IPv4/IPv6)

Took the occasion to also add some module tests (not present before)

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@LucaPrete
Copy link
Member Author

LucaPrete commented Oct 21, 2023 •
edited
Loading

[please wait before merging. A few more tests in progress]

ludoo
ludoo approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice, thanks Luca

@LucaPrete
Copy link
Member Author

Finished the tests, also with IPv6. I'll merge.

@LucaPrete LucaPrete merged commit a23b3d6 into master Oct 21, 2023
13 checks passed
@LucaPrete LucaPrete deleted the net_lb_ext_support_dualstack_multiple_backends branch October 21, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucaPrete @ludoo