Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incompatible balancing_mode #1769

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Oct 17, 2023

balancing_mode review.

net-lb-int

  • Fix error on apply of example:
Error creating RegionBackendService: googleapi: Error 400: Invalid value for field 'resource.backends[0].balancingMode': 'UTILIZATION'. Balancing mode must be CONNECTION for an INTERNAL backend service., invalid
  • remove unused balancing_mode variable, as only one value is possible anyhow

net-lb-ext

  • update in the backends description

net-lb-proxy-int

  • update in the backends description

net-lb-app-int

  • added validation of balancing_mode
  • fixed other validations

net-lb-app-ext

  • added validation of balancing_mode
  • fixed other validations
  • removed validation for locality_lb_policy as this variable is not used in this module

Closes: #1767

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. As you were saying in chat, we might want to not even expose balancing mode anymore.

@wiktorn wiktorn requested a review from ludoo October 17, 2023 19:57
@wiktorn
Copy link
Collaborator Author

wiktorn commented Oct 17, 2023

Great catch. As you were saying in chat, we might want to not even expose balancing mode anymore.

This went a bit bigger as I followed the white rabbit. Please re-check.

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff

@wiktorn wiktorn merged commit c21fa45 into GoogleCloudPlatform:master Oct 18, 2023
9 checks passed
@wiktorn wiktorn deleted the ilb_example_fix branch October 18, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net-lb*-int - backends[].balancing mode - review possibile values
2 participants