-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove incompatible balancing_mode #1769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch. As you were saying in chat, we might want to not even expose balancing mode anymore.
25b2578
to
d5672dc
Compare
This went a bit bigger as I followed the white rabbit. Please re-check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff
balancing_mode
review.net-lb-int
balancing_mode
variable, as only one value is possible anyhownet-lb-ext
backends
descriptionnet-lb-proxy-int
backends
descriptionnet-lb-app-int
balancing_mode
net-lb-app-ext
balancing_mode
locality_lb_policy
as this variable is not used in this moduleCloses: #1767
Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py