Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dual stack and multiple forwarding rules to net-lb-int module #1765

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Add support for dual stack and multiple forwarding rules to net-lb-int module #1765

merged 5 commits into from
Oct 17, 2023

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented Oct 16, 2023 •
edited by ludoo
Loading

The PR adds support for:

  • dual stack: being able to configure both IPv4 and IPv6 addresses on the same ILB
  • use of multiple forwarding rules (indeed, both IPv4 and IPv6), thus being able to expose multiple frontend IPs

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Fixes #1764

@LucaPrete LucaPrete requested review from ludoo and juliocc October 16, 2023 17:34
ludoo
ludoo requested changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice find Luca, dropped a couple minor comments

modules/net-lb-int/README.md Show resolved Hide resolved
modules/net-lb-int/variables.tf Outdated Show resolved Hide resolved
modules/net-lb-int/main.tf Outdated Show resolved Hide resolved
@LucaPrete LucaPrete requested review from wiktorn and ludoo October 16, 2023 21:18
@LucaPrete
Copy link
Member Author

LucaPrete commented Oct 16, 2023 •
edited
Loading

Thanks folks! I'm not super convinced to leave the key of the terraform state set to "" if we don't specify forwarding rules. We still have the choice to set it somehow to "default" in that case. At the same time, it might be confusing for users, as it wouldn't correspond to the default dictionary key. Let me know what you think. Thank you

@LucaPrete LucaPrete changed the title [#1764] Add support for dual stack and multiple forwarding rules [#1764] net-lb-int: add support for dual stack and multiple forwarding rules Oct 16, 2023
@LucaPrete LucaPrete enabled auto-merge (squash) October 17, 2023 09:13
@LucaPrete LucaPrete merged commit 6c48512 into master Oct 17, 2023
13 checks passed
@LucaPrete LucaPrete deleted the net_lb_support_dualstack_multiple_backends branch October 17, 2023 09:30
@ludoo ludoo changed the title [#1764] net-lb-int: add support for dual stack and multiple forwarding rules Add support for dual stack and multiple forwarding rules to net-lb-int module Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

@ludoo ludoo ludoo approved these changes

@juliocc juliocc Awaiting requested review from juliocc

Assignees
No one assigned
Labels
on:blueprints on:FAST on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net-lb-int - add support for dual stack (IPv4 and IPv6) and for multiple FE IPs (forwarding rules)
3 participants
@LucaPrete @ludoo @wiktorn