Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposed stack_type variable in compute_vm module #1756

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Exposed stack_type variable in compute_vm module #1756

merged 3 commits into from
Oct 16, 2023

Conversation

luigi-bitonti
Copy link
Contributor

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@ludoo
Copy link
Collaborator

ludoo commented Oct 15, 2023

Fixes #1740

ludoo
ludoo reviewed Oct 15, 2023
View reviewed changes
modules/compute-vm/main.tf Outdated Show resolved Hide resolved
ludoo
ludoo approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed variable ordering and aligned the instance template resource to the instance

@ludoo ludoo enabled auto-merge (squash) October 16, 2023 06:10
@ludoo ludoo requested a review from juliocc October 16, 2023 06:11
@ludoo ludoo merged commit 0195ea6 into GoogleCloudPlatform:master Oct 16, 2023
9 checks passed
@luigi-bitonti luigi-bitonti deleted the vm_feature branch October 18, 2023 13:24
@dominicrjames dominicrjames mentioned this pull request Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@juliocc juliocc Awaiting requested review from juliocc

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luigi-bitonti @ludoo